Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo on ESLint website does not include new rules #8237

Closed
not-an-aardvark opened this issue Mar 12, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@not-an-aardvark
Copy link
Member

commented Mar 12, 2017

What did you do?

I went to http://eslint.org/demo/ and looked at the list of checkboxes.

What did you expect to happen?

I expected no-compare-neg-zero (a rule introduced in 3.17.0) to appear in the list of checkboxes.

What actually happened? Please include the actual, raw output from ESLint.

no-compare-neg-zero is not in the list of checkboxes.

The release script produced this error, which is probably related:

cp: no such file or directory: conf/eslint.json

@platinumazure: I assigned you to this issue since you mentioned you wanted to work on this, but feel free to unassign yourself if that's not the case.

@ilyavolodin

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

Easiest way would probably be to modify demo code to stop using eslint.json file all together. We are already retrieving all of the rules from the the API. I'll see if I can take a look at it tomorrow.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

I've pushed branches that should be at least 70% of the way there. Unfortunately I have to be somewhere very soon so I don't yet have time to test (apologies if it turns out they're completely broken), but if anyone else wants to, feel free.

@ilyavolodin Is this pretty close to the approach you were going for?

@ilyavolodin

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

Actually demo.js file is the old demo code, it's not used anymore. I guess I forgot to remove it after the demo re-write. I opened a PR to the website repo with the changes to drop eslint.json file.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

@ilyavolodin Thanks, sorry for not looking closely enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.