Fix: no-multiple-empty-lines crash on space after last \n (fixes #8401) #8402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, no-multiple-empty-lines would crash if it tried to remove a trailing newline followed by a space from the end of a file. This commit fixes the crash.
not-an-aardvark
added
accepted
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @RRMoelker, @alberto and @gcochard to be potential reviewers. |
|
LGTM |
ilyavolodin
approved these changes
Apr 3, 2017
platinumazure
approved these changes
Apr 3, 2017
gyandeeps
reviewed
Apr 4, 2017
lib/rules/no-multiple-empty-lines.js
Outdated
| */ | ||
| const lineNumberAfterRemovedLines = lineNumber - maxAllowed; | ||
| const rangeEnd = lineNumberAfterRemovedLines <= allLines.length | ||
| ? sourceCode.getIndexFromLoc({ line: lineNumber - maxAllowed, column: 0 }) |
There was a problem hiding this comment.
nit: but u can use the variable lineNumberAfterRemovedLines here also.
gyandeeps
approved these changes
Apr 4, 2017
|
LGTM |
platinumazure
approved these changes
Apr 4, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8401)
What changes did you make? (Give an overview)
Previously, no-multiple-empty-lines would crash if it tried to remove a trailing newline followed by a space from the end of a file. This commit fixes the crash.
Is there anything you'd like reviewers to focus on?
Nothing in particular