Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update:del duplicated test. #8527

Merged
merged 1 commit into from Apr 29, 2017
Merged

Update:del duplicated test. #8527

merged 1 commit into from Apr 29, 2017

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 29, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslintbot
Copy link

LGTM

@platinumazure platinumazure added chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules labels Apr 29, 2017
@platinumazure
Copy link
Member

Thanks for the PR, @aladdin-add! This seems reasonable to me but I'd like another team member to look too.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note to merger: This should probably be a Chore, not an Update.

@gyandeeps gyandeeps merged commit 025e97a into eslint:master Apr 29, 2017
@aladdin-add aladdin-add deleted the patch-2 branch April 29, 2017 20:36
kgregory pushed a commit to kgregory/eslint that referenced this pull request May 1, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants