Update: make indent MemberExpression handling more robust (fixes #8552) #8554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#8552)
What changes did you make? (Give an overview)
This commit updates the indent rule's MemberExpression handler to avoid expecting NaN indentation when the MemberExpression option is set to "off". It also fixes a related bug with indenting MemberExpressions with parenthesized objects, and adds a few comments to clarify why particular pieces of the MemberExpression logic are necessary.
Is there anything you'd like reviewers to focus on?
Nothing in particular