New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: add --fix to no-debugger (fixes #8659) #8660
Conversation
LGTM |
@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @vitorbal and @btmills to be potential reviewers. |
should also update the docs? |
@aladdin-add Please update the docs. Checkout this commit for a sample of what should be added. |
LGTM |
Updating docs is no longer required. Build will automatically insert appropriate text in the right spot for rules that are fixable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion around docs. Can you remove the change to the docs? Then this will be ready to go!
9960d1d
to
d07da50
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @aladdin-add!
@btmills done. I thought the build will check it... |
Not sure the change complies with
I wanted to use Temporary have to write // eslint-disable-next-line
debugger; +300% to length in each case 😃 Not sure autofixing |
@kachkaev Long-term, what we are hoping is that editor integrations will be able to go through fixable errors and choose which autofixes to apply or not. Recent versions of ESLint should provide all the information the integration would need (i.e., which rule is reporting a particular violation, whether or not the error is fixable, etc.); it should be possible for the integration to filter out certain types of fixable errors and just report them without fixing them. So in short, I would recommend filing an issue on the GitHub repo for your editor integration. |
What is the purpose of this pull request? (put an "X" next to item)
[x] Add autofixing to a rule
What changes did you make? (Give an overview)
add --fix to
no-debugger
. (fixes #8659 )Is there anything you'd like reviewers to focus on?