Chore: remove ConfigOps.normalize in favor of ConfigOps.getRuleSeverity #9224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This removes the
normalize
method fromconfig-ops
in favor of agetRuleSeverity
method.Previously,
ConfigOps.normalize
would only convert string severities to numeric severities, but it would still leave severities in arrays, andLinter
used a separategetRuleSeverity
function to extract them. NowConfigOps.getRuleSeverity
handles both operations, so thegetRuleSeverity
function inLinter
is redundant.The goal of this change is to (a) reduce the number of places where modules mutate each others' objects, and (b) organize the rule severity logic into one place.
Is there anything you'd like reviewers to focus on?
Nothing in particular