Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add Aladdin-ADD & VictorHom to README #9424

Merged
merged 1 commit into from Oct 12, 2017
Merged

Chore: Add Aladdin-ADD & VictorHom to README #9424

merged 1 commit into from Oct 12, 2017

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Oct 12, 2017 •
edited

Welcome, @aladdin-add & @VictorHom!

@eslintbot
Copy link

LGTM

not-an-aardvark
not-an-aardvark approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

platinumazure
platinumazure approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@aladdin-add
Copy link
Member

so, I was able to merge? 😉

@kaicataldo kaicataldo merged commit 30d018b into master Oct 12, 2017
@kaicataldo kaicataldo added the chore This change is not user-facing label Oct 12, 2017
@ilyavolodin ilyavolodin deleted the new-committers branch October 12, 2017 22:38
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 11, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@gyandeeps gyandeeps gyandeeps approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kaicataldo @eslintbot @aladdin-add @platinumazure @gyandeeps @not-an-aardvark