New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in behavior of 'indent' rule in 4.18.0 #9995
Closed
zbjornson opened this issue
Feb 20, 2018
· 1 comment
· Fixed by Urigo/tortilla#62, yhirano55/ama#57, annict/annict#1039, dependabot/dependabot-core#312 or dependabot/dependabot-core#313
Closed
Change in behavior of 'indent' rule in 4.18.0 #9995
zbjornson opened this issue
Feb 20, 2018
· 1 comment
· Fixed by Urigo/tortilla#62, yhirano55/ama#57, annict/annict#1039, dependabot/dependabot-core#312 or dependabot/dependabot-core#313
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
indent
Relates to the `indent` rule
rule
Relates to ESLint's core rules
Comments
Thanks for the report, I can reproduce this issue. |
not-an-aardvark
added a commit
that referenced
this issue
Mar 3, 2018
This updates the `indent` rule to ensure that the tokens in a non-ignored node are always indented at least as much as the first token of the node. This fixes an issue where some tokens would not have enough indentation if their node's listener did not explicitly give them an offset.
This was referenced Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
indent
Relates to the `indent` rule
rule
Relates to ESLint's core rules
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default with
ecmaVersion: 8
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
This was valid in 4.17.0:
but 4.18.0 wants it formatted like:
This only happens if there's a
!
in front of the[].some
bit.What did you expect to happen?
Same behavior as 4.17.0, per above.
What actually happened? Please include the actual, raw output from ESLint.
The text was updated successfully, but these errors were encountered: