New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Use strict equality in RuleTester comparisons (fixes #9417) #10008

merged 2 commits into from Mar 22, 2018


3 participants

not-an-aardvark commented Feb 23, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Add something to the core

What changes did you make? (Give an overview)

This updates RuleTester to use strict equality comparisons where it previously used loose equality, as described in #9417.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark merged commit 2a7ecaa into master Mar 22, 2018

5 checks passed

commit-message PR title follows commit message guidelines
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
licence/cla Contributor License Agreement is signed.
release-monitor No patch release is pending

v5.0.0 automation moved this from Ready to merge to Done Mar 22, 2018

@not-an-aardvark not-an-aardvark deleted the rule-tester-strict-equality branch Mar 22, 2018

@eslint eslint bot locked and limited conversation to collaborators Sep 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.