Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: make library files non-executable #10021

Merged
merged 1 commit into from Feb 26, 2018
Merged

Conversation

@not-an-aardvark
Copy link
Member

not-an-aardvark commented Feb 25, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

lib/linter.js and lib/rules/template-tag-spacing.js are marked as executable but aren't actually valid executable files. This commit marks them as non-executable.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark force-pushed the no-executable-linter branch from e5ca74b to 711a7b6 Feb 25, 2018
@not-an-aardvark not-an-aardvark changed the title Chore: make lib/linter.js non-executable Chore: make library files non-executable Feb 25, 2018
@not-an-aardvark not-an-aardvark force-pushed the no-executable-linter branch 3 times, most recently from 0644000 to 1006440 Feb 25, 2018
@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Feb 25, 2018

Could you explain what you mean by "marked as executable"? I'm pretty sure this is something I'm not familiar with, and since diff doesn't show anything, it's hard to review.

@not-an-aardvark

This comment has been minimized.

Copy link
Member Author

not-an-aardvark commented Feb 25, 2018

All files have an "execute bit" stored as part of their metadata, which indicates whether the file can be executed on its own (e.g. as ./foo.js rather than node foo.js). Since lib/linter.js previously had its execute bit set, it was possible to run lib/linter.js in a shell and have it be interpreted as a bash script. However, this was not useful for anything and would generally result in a syntax error. The bit was probably not set intentionally.

Copy link
Member

platinumazure left a comment

LGTM. Something to think about later: Is there an ESLint plugin or a more generalized pre-commit hook we could add to avoid this in future?

@not-an-aardvark

This comment has been minimized.

Copy link
Member Author

not-an-aardvark commented Feb 26, 2018

I don't know of any existing plugins. (I found these files with fselect.) Maybe that could be something added to eslint-plugin-node.

@not-an-aardvark not-an-aardvark merged commit 33177cd into master Feb 26, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@not-an-aardvark not-an-aardvark deleted the no-executable-linter branch Feb 26, 2018
This was referenced Mar 22, 2018
@renovate renovate bot mentioned this pull request Mar 23, 2018
@eslint eslint bot locked and limited conversation to collaborators Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.