Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Uncommented test for empty program for no-invalid-meta #10046

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@platinumazure
Copy link
Member

platinumazure commented Mar 2, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Follow-up to #9698.

What changes did you make? (Give an overview)

Uncommented a test that should be invalid but is currently valid, so fails RuleTester. Depends on #9534.

Is there anything you'd like reviewers to focus on?

Not really. Just know that CI will fail until #9534 is fixed, at which point I will rebase.

@platinumazure platinumazure force-pushed the uncomment-no-invalid-meta-test branch from ff7143e to e16b53c Mar 22, 2018

@platinumazure platinumazure merged commit 837edc7 into master Mar 22, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@platinumazure platinumazure deleted the uncomment-no-invalid-meta-test branch Mar 22, 2018

@eslint eslint bot locked and limited conversation to collaborators Sep 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.