Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update ECMAScript versions in FAQ #10047

Merged
merged 2 commits into from Mar 4, 2018
Merged

Docs: Update ECMAScript versions in FAQ #10047

merged 2 commits into from Mar 4, 2018

Conversation

@alberto
Copy link
Member

@alberto alberto commented Mar 2, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Update the information about supported ES versions to FAQ.

Is there anything you'd like reviewers to focus on?
No.

@eslint eslint bot added the triage label Mar 2, 2018
README.md Outdated

ESLint has full support for ECMAScript 6. By default, this support is off. You can enable ECMAScript 6 syntax and global variables through [configuration](https://eslint.org/docs/user-guide/configuring).
ESLint has full support for ECMAScript 3, 5 (default), 6, 7, 8, or 9. You can set your desired ECMAScript syntax (and other settings, like global variables or your target environments) through [configuration](https://eslint.org/docs/user-guide/configuring).

This comment has been minimized.

@mysticatea

mysticatea Mar 2, 2018
Member

I like year style; 3, 5, 2015, 2016, 2017, or 2018.

README.md Outdated

ESLint has full support for ECMAScript 6. By default, this support is off. You can enable ECMAScript 6 syntax and global variables through [configuration](https://eslint.org/docs/user-guide/configuring).
ESLint has full support for ECMAScript 3, 5 (default), ES2015, ES2016, ES2017, and ES2018. You can set your desired ECMAScript syntax (and other settings, like global variables or your target environments) through [configuration](https://eslint.org/docs/user-guide/configuring).

This comment has been minimized.

@not-an-aardvark

not-an-aardvark Mar 3, 2018
Member

Very minor nitpick: I think it's redundant to say "ECMAScript ES2015". Maybe it would be better to say "ECMAScript 3, 5 (default), 2015, 2016, 2017, and 2018".

This comment has been minimized.

@alberto

alberto Mar 3, 2018
Author Member

oh, right

@alberto alberto force-pushed the readme-es-versions branch from 58621cc to 6a7f643 Mar 3, 2018
@alberto alberto force-pushed the readme-es-versions branch from 6a7f643 to 9a90201 Mar 3, 2018
@btmills
btmills approved these changes Mar 3, 2018
@gyandeeps gyandeeps merged commit 2a4c838 into master Mar 4, 2018
5 checks passed
5 checks passed
commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@not-an-aardvark not-an-aardvark deleted the readme-es-versions branch Mar 4, 2018
This was referenced Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 2, 2018
@eslint eslint bot added the archived due to age label Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.