Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Correctly indent JSXText with trailing linebreaks (fixes #9878) #10055

Merged
merged 1 commit into from Mar 6, 2018

Conversation

@not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Mar 3, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (#9878)

What changes did you make? (Give an overview)

This fixes a bug in the indent rule where a line comparison with the end of a token would use the end location of any trailing whitespace in the token, rather than the location of the last non-whitespace character in the token. This behavior went against user intuition for tokens with trailing whitespace.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This fixes a bug in the `indent` rule where a line comparison with the end of a token would use the end location of any trailing whitespace in the token, rather than the location of the last non-whitespace character in the token. This behavior went against user intuition for tokens with trailing whitespace.
@not-an-aardvark not-an-aardvark merged commit 72ca5b3 into master Mar 6, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@not-an-aardvark not-an-aardvark deleted the jsx-text-after-element branch Mar 6, 2018
This was referenced Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 3, 2018
@eslint eslint bot added the archived due to age label Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.