Docs: fix possible typo #10060
Merged
Docs: fix possible typo #10060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
platinumazure
approved these changes
Mar 6, 2018
LGTM, thanks for contributing! Just want another set of eyes on this.
not-an-aardvark
reviewed
Mar 6, 2018
docs/rules/quote-props.md
Outdated
| @@ -42,7 +42,7 @@ String option: | |||
|
|
|||
| * `"always"` (default) requires quotes around all object literal property names | |||
| * `"as-needed"` disallows quotes around object literal property names that are not strictly required | |||
| * `"consistent"` enforces a consistent quote style requires quotes around object literal property names | |||
| * `"consistent"` enforces a consistent quote style | |||
There was a problem hiding this comment.
Could this be expanded to something like:
"consistent"enforces a consistent quote style; in a given object, either all of the properties should be quoted, or none of the properties should be quoted.
My concern is that "a consistent quote style" could be misinterpreted, given that all of the options enforce some level of "consistency" (on the level of an entire codebase rather than an individual object).
aladdin-add
approved these changes
Mar 6, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The removed part seems wrong, like copy-paste artifact.
Is there anything you'd like reviewers to focus on?
No. Sorry if I am wrong.