Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix possible typo #10060

Merged
merged 1 commit into from Mar 6, 2018
Merged

Docs: fix possible typo #10060

merged 1 commit into from Mar 6, 2018

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The removed part seems wrong, like copy-paste artifact.

Is there anything you'd like reviewers to focus on?

No. Sorry if I am wrong.

@eslint-deprecated eslint-deprecated bot added the triage label Mar 6, 2018
Copy link
Member

@platinumazure platinumazure left a comment

LGTM, thanks for contributing! Just want another set of eyes on this.

@@ -42,7 +42,7 @@ String option:

* `"always"` (default) requires quotes around all object literal property names
* `"as-needed"` disallows quotes around object literal property names that are not strictly required
* `"consistent"` enforces a consistent quote style requires quotes around object literal property names
* `"consistent"` enforces a consistent quote style
Copy link
Member

@not-an-aardvark not-an-aardvark Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be expanded to something like:

"consistent" enforces a consistent quote style; in a given object, either all of the properties should be quoted, or none of the properties should be quoted.

My concern is that "a consistent quote style" could be misinterpreted, given that all of the options enforce some level of "consistency" (on the level of an entire codebase rather than an individual object).

Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aladdin-add aladdin-add merged commit 66a1e9a into eslint:master Mar 6, 2018
5 checks passed
@vsemozhetbyt vsemozhetbyt deleted the patch-1 branch Mar 6, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 3, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age label Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants