Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Wrap `Buffer()` in backticks in `no-buffer-constructor` rule description #10084

Merged
merged 1 commit into from Mar 14, 2018

Conversation

@ntwb
Copy link
Contributor

@ntwb ntwb commented Mar 13, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Wraps Buffer() in backticks in the no-buffer-constructor rule description

Adds further consistency to already backtick'd code in rule docs and descriptions:

https://eslint.org/docs/rules/#nodejs-and-commonjs
https://eslint.org/docs/rules/no-buffer-constructor

Is there anything you'd like reviewers to focus on?

Nope, just thanks, and have a great day 馃槃

@eslint eslint bot added the triage label Mar 13, 2018
@aladdin-add aladdin-add added documentation and removed triage labels Mar 14, 2018
@aladdin-add aladdin-add changed the title Wrap `Buffer()` in backticks in `no-buffer-constructor` rule description Docs: Wrap `Buffer()` in backticks in `no-buffer-constructor` rule description Mar 14, 2018
@aladdin-add aladdin-add merged commit 72ed3db into eslint:master Mar 14, 2018
4 of 5 checks passed
4 of 5 checks passed
commit-message Commit message doesn't follow guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
This was referenced Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.