Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify default ignoring of node_modules #10092

Conversation

@matijs
Copy link
Contributor

@matijs matijs commented Mar 16, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
When using ESLint from the root of a mono repo node_modules needs to
be explicitly added to .eslintignore for ESLint to ignore for example
packages/*/node_modules. Clarified this in the configuring
documentation.

@eslint eslint bot added the triage label Mar 16, 2018
@matijs matijs force-pushed the matijs:improvement/clarify-eslintignore-in-configuration branch from e775938 to 9fde686 Mar 16, 2018
When using ESLint from the root of a mono repo `node_modules` needs to
be explicitly added to `.eslintignore` for ESLint to ignore for example
`packages/*/node_modules`. Clarified this in the configuring
documentation.
@matijs matijs force-pushed the matijs:improvement/clarify-eslintignore-in-configuration branch from 9fde686 to 4dd0aec Mar 16, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

LGTM, thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit 935f4e4 into eslint:master Mar 16, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
This was referenced Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.