Clarify default ignoring of node_modules #10092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
When using ESLint from the root of a mono repo `node_modules` needs to be explicitly added to `.eslintignore` for ESLint to ignore for example `packages/*/node_modules`. Clarified this in the configuring documentation.
aladdin-add
added
enhancement
ilyavolodin
approved these changes
Mar 16, 2018
not-an-aardvark
approved these changes
Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 22, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
When using ESLint from the root of a mono repo
node_modulesneeds tobe explicitly added to
.eslintignorefor ESLint to ignore for examplepackages/*/node_modules. Clarified this in the configuringdocumentation.