Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify default ignoring of node_modules #10092

Merged
merged 1 commit into from Mar 16, 2018
Merged

Clarify default ignoring of node_modules #10092

merged 1 commit into from Mar 16, 2018

Conversation

matijs
Copy link
Contributor

@matijs matijs commented Mar 16, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
When using ESLint from the root of a mono repo node_modules needs to
be explicitly added to .eslintignore for ESLint to ignore for example
packages/*/node_modules. Clarified this in the configuring
documentation.

@eslint-deprecated eslint-deprecated bot added the triage label Mar 16, 2018
When using ESLint from the root of a mono repo `node_modules` needs to
be explicitly added to `.eslintignore` for ESLint to ignore for example
`packages/*/node_modules`. Clarified this in the configuring
documentation.
@aladdin-add aladdin-add added enhancement documentation evaluating and removed triage labels Mar 16, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

LGTM, thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit 935f4e4 into eslint:master Mar 16, 2018
5 checks passed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 13, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age label Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age documentation enhancement evaluating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants