Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add modified variable examples for no-loop-func (fixes #9527) #10098

Merged
merged 1 commit into from Mar 24, 2018

Conversation

Projects
None yet
4 participants
@rachx
Copy link
Contributor

rachx commented Mar 19, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Add incorrect examples where the function within the loop refers to a variable from the outer scope that is later modified. (This contrasts with the last correct example.)

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint eslint bot added the triage label Mar 19, 2018

@platinumazure
Copy link
Member

platinumazure left a comment

LGTM, but would like another set of eyes to review. Thanks!

@platinumazure platinumazure requested a review from mysticatea Mar 19, 2018

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Mar 19, 2018

Closing/reopening to try to force CLA check to work.

@not-an-aardvark

This comment has been minimized.

Copy link
Member

not-an-aardvark commented Mar 19, 2018

Closing/reopening again since the CLA checker is apparently fixed.

@not-an-aardvark not-an-aardvark merged commit 692e383 into eslint:master Mar 24, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@not-an-aardvark

This comment has been minimized.

Copy link
Member

not-an-aardvark commented Mar 24, 2018

Thanks for contributing!

@eslint eslint bot locked and limited conversation to collaborators Sep 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.