Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Adding log at beginning of unit tests in Makefile.js #10102

Merged
merged 1 commit into from Mar 20, 2018

Conversation

@platinumazure
Copy link
Member

@platinumazure platinumazure commented Mar 19, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Added a message "Running unit tests" to help indicate to developers when npm test has transitioned from linting to unit tests. Not high-value but does slightly improve the developer experience.

What changes did you make? (Give an overview)

Added message "Running unit tests" to the test target in Makefile.js. It is output after all of the lint targets but before unit tests and coverage start.

Is there anything you'd like reviewers to focus on?

Not really.

@platinumazure platinumazure merged commit a717c5d into master Mar 20, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
@platinumazure platinumazure deleted the makefile-test-message branch Mar 20, 2018
This was referenced Mar 22, 2018
This was referenced Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.