Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove eslint vs jshint from faq #10108

Merged
merged 1 commit into from Mar 27, 2018

Conversation

Projects
None yet
4 participants
@alberto
Copy link
Member

alberto commented Mar 20, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Remove eslint vs jshint justification from the FAQ. eslint is vastly more popular than jshint these days, I don't think there is a need to justify its existence anymore.

Is there anything you'd like reviewers to focus on?
No.

@eslint eslint bot added the triage label Mar 20, 2018

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Mar 20, 2018

I've approved and I'm still okay with this going in, but do we want to leave any info such as how to migrate from JSHint?

Of course, we could also create a new documentation page for things like this as well (including, if desired, how the linters compare).

@alberto

This comment has been minimized.

Copy link
Member Author

alberto commented Mar 21, 2018

I'm not sure there is a clear migration strategy. We could create a page like https://eslint.org/docs/user-guide/migrating-from-jscs for jshint if we wanted to, but I would treat that as a different issue.

@platinumazure platinumazure merged commit 9e66bfb into master Mar 27, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@platinumazure platinumazure deleted the readme-jshint branch Mar 27, 2018

@eslint eslint bot locked and limited conversation to collaborators Sep 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.