Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update: Make no-cond-assign work for ternaries (fixes #10091) #10109
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
Addresses issue #10091
What changes did you make? (Give an overview)
Could you please change the commit message so it begins with "Update:"? We use "Update" for bugfixes that introduce more warnings, to force the change to be semver-minor as a small concession to users who need to make changes for bugfixes that cause more warnings. Thanks!
That's a great question, thanks for asking (and congratulations on your first pull request). You can amend and force-push, which will satisfy our status check. Optionally, you can edit the PR title separately for consistency, but that's not required.…
On Wed, Mar 21, 2018, 17:44 Aaron Harper ***@***.***> wrote: How do I change the commit message? Do I amend my commit, then force push? Or will that screw up the pull request? Sorry for the dumb question. This is my first pull request. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10109 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWeherIBPSotQl9OXcoJZJpzCRAZuXks5tgtffgaJpZM4Sy7sO> .
That would be great. You might not need the `var x` since our rule tests don't care about unresolved global variables. Either way is fine.…
On Wed, Mar 21, 2018, 17:54 Aaron Harper ***@***.***> wrote: I also forgot to add a valid test. Should I add the following line to the valid array, and then make a new commit? "var x; var b = (x === 0) ? 1 : 0;" — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10109 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWehfPj-rzoXvAiLlR_x-gH2Z-uf48ks5tgto8gaJpZM4Sy7sO> .