Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update ambiguous for...in example for guard-for-in #10114

Merged
merged 1 commit into from Mar 21, 2018

Conversation

@w3cj
Copy link
Contributor

@w3cj w3cj commented Mar 21, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
It's unclear that the for...in example of correct usage is showing 2 different options. I split them into 2 separate examples.

Is there anything you'd like reviewers to focus on?
No

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Mar 21, 2018

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Mar 21, 2018
Copy link
Member

@platinumazure platinumazure left a comment

LGTM, thanks for contributing!

Could you please amend your commit message to follow our commit message guidelines? Thanks!

@w3cj w3cj force-pushed the w3cj:patch-1 branch from 759db0d to 4f9de22 Mar 21, 2018
@w3cj w3cj changed the title Update ambiguous for...in example Docs: Update ambiguous for...in example for guard-for-in Mar 21, 2018
@platinumazure platinumazure merged commit 6f9e155 into eslint:master Mar 21, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure
Copy link
Member

@platinumazure platinumazure commented Mar 21, 2018

Thanks for contributing!

This was referenced Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.