New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor --no-ignore flag logic #10146

Merged
merged 2 commits into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@not-an-aardvark
Member

not-an-aardvark commented Mar 30, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

While working on #10143 I noticed that the addFile function in glob-util was very complex and hard to read. I refactored it to make it more readable.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@platinumazure

LGTM, thanks! Just a few small suggestions for readability/maintainability (mostly around combinations of logical-and and logical-or).

const shouldProcessCustomIgnores = options.ignore !== false;
const shouldLintIgnoredDirectPaths = options.ignore === false;
const fileMatchesIgnorePatterns = ignoredPaths.contains(filename, "default") ||
shouldProcessCustomIgnores && ignoredPaths.contains(filename, "custom");

This comment has been minimized.

@platinumazure

platinumazure Mar 30, 2018

Member

I would love to see this parenthesized, just to avoid any possibility of ambiguity for future readers.

}
if (added[filename]) {
return;
if (!fileMatchesIgnorePatterns || isDirectPath && shouldLintIgnoredDirectPaths) {

This comment has been minimized.

@platinumazure

platinumazure Mar 30, 2018

Member

I'd love to see parentheses here (around the && expression) for readability, as well.

@not-an-aardvark not-an-aardvark merged commit 9a020dc into master Mar 30, 2018

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the refactor-ignore-checking branch Mar 30, 2018

@eslint eslint bot locked and limited conversation to collaborators Sep 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.