New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Upgrade to Espree v4 alpha (refs #9990) #10152

Merged
merged 2 commits into from Mar 30, 2018

Conversation

Projects
2 participants
@btmills
Member

btmills commented Mar 30, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Upgrade to the Espree v4 alpha and remove now-redundant experimentalObjectRestSpread tests.

What changes did you make? (Give an overview)

This upgrades Espree to v4.0.0-alpha.0 and removes our duplicated tests that pair experimentalObjectRestSpread and ecmaVersion: 2018. It does not implement the deprecation warning or translating the former to the latter in the background. It also enables ecmaVersion: 2018 in the config initializer when React is enabled instead of enabling experimentalObjectRestSpread.

Is there anything you'd like reviewers to focus on?

All of the tests that were deleted should have an existing pair that's equivalent except for using ecmaVersion: 2018 instead of experimentalObjectRestSpread.

@eslint eslint bot added the triage label Mar 30, 2018

@btmills btmills changed the title from Breaking: Upgrade to Espree v4 alpha to Breaking: Upgrade to Espree v4 alpha (refs #9990) Mar 30, 2018

btmills added some commits Mar 30, 2018

Breaking: Upgrade to Espree v4 alpha (refs #9990)
This upgrades Espree to v4.0.0-alpha.0 and removes our duplicated tests
that pair `experimentalObjectRestSpread` and `ecmaVersion: 2018`. It
does not implement the deprecation warning or translating the former to
the latter in the background.
@not-an-aardvark

LGTM, thanks!

@not-an-aardvark not-an-aardvark added this to Ready to merge in v5.0.0 Mar 30, 2018

@btmills btmills merged commit f4b3af5 into master Mar 30, 2018

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

v5.0.0 automation moved this from Ready to merge to Done Mar 30, 2018

@btmills btmills deleted the espree-v4 branch Mar 30, 2018

@eslint eslint bot locked and limited conversation to collaborators Sep 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.