Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update issue templates #10900

Merged
merged 1 commit into from Sep 28, 2018

Conversation

@nzakas
Copy link
Member

commented Sep 27, 2018

Add emoji to issue template selection screen for easier scanning.

@eslint eslint bot added the triage label Sep 27, 2018

@nzakas

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2018

Oops, need to get the security and question templates in. Please don't merge yet.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

I'm a bit confused. I see 4 new files, and then edits to 4 files that seem pretty similar conceptually.

Put another way: For each of our 4 major issue template cases-- bug, new rule, rule change, non-rule change-- I'm seeing a new file and an edit to an existing file.) I don't understand what the relationship between each pair of files. Was the intent to replace one set of templates with the other? If so, should the other 4 files be deleted, not edited?

Hopefully I'm just missing something simple. 😄

@nzakas

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2018

@platinumazure see my previous comment about the GitHub UI doing this.

@nzakas nzakas force-pushed the issue-template-emoji branch from 5b8f033 to 30ae892 Sep 27, 2018

@nzakas nzakas added chore and removed triage labels Sep 27, 2018

@nzakas nzakas changed the title Chore: Add Emoji to issue template selection Chore: Update issue templates Sep 27, 2018

@platinumazure
Copy link
Member

left a comment

Minor typo, otherwise LGTM. Thanks for contributing, this will be super helpful!

.github/ISSUE_TEMPLATE/SECURITY.md Outdated Show resolved Hide resolved
@ilyavolodin
Copy link
Member

left a comment

Other then the typo that @platinumazure mentioned

Chore: Update issue templates
* Add emoji to issue template selection screen for easier scanning.
* Add Security issue template directing people to HackerOne
* Add Question issue template directing people to mailing list and
chatroom

@nzakas nzakas force-pushed the issue-template-emoji branch from 30ae892 to d1e4792 Sep 28, 2018

Comment has been addressed.

@not-an-aardvark not-an-aardvark merged commit 2e52bca into master Sep 28, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

@not-an-aardvark not-an-aardvark deleted the issue-template-emoji branch Sep 28, 2018

@eslint eslint bot locked and limited conversation to collaborators Mar 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.