Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: table to version 5 #10903

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@realityking
Copy link
Contributor

commented Sep 29, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Bumping table to its newest version. The breaking change is that version 5 requires Node.js 6.

Biggest advantage is that it loses a couple of dependencies, notably ajv-keywords - that disaster can't happen again 馃槅

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Sep 29, 2018

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@ilyavolodin ilyavolodin added chore and removed triage labels Oct 1, 2018

@not-an-aardvark not-an-aardvark merged commit 70bde69 into eslint:master Oct 1, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@realityking realityking deleted the realityking:upgrade-table branch Oct 1, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Mar 31, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.