Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: iife statement type for padding-line-between-statements (fixes #10853) #10916

Merged
merged 1 commit into from Oct 12, 2018

Conversation

@platinumazure
Copy link
Member

commented Oct 3, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

See #10853.

What changes did you make? (Give an overview)

Added "iife" statement type to padding-line-between-statements rule.

Is there anything you'd like reviewers to focus on?

  • Any issues with the documentation changes I've added?
  • Are there any more tests I should add?

@platinumazure platinumazure force-pushed the issue10853 branch from 3a99b5e to 015648c Oct 3, 2018

@kaicataldo kaicataldo added accepted and removed evaluating labels Oct 4, 2018

@kaicataldo

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

#10853 has enough support from the team and this is now accepted.

@btmills
Copy link
Member

left a comment

LGTM. You weren't kidding on the issue when you said the implementation would be minimal 😆

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 6cb63fd into master Oct 12, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the issue10853 branch Oct 12, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.