Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-extra-bind No autofix if arg may have side effect (fixes #10846) #10918

Merged
merged 2 commits into from Oct 12, 2018

Conversation

@platinumazure
Copy link
Member

commented Oct 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Ensure autofix is only performed if the argument to .bind() is definitely side-effect free. For most practical situations, this means ensuring the argument is a Literal, Identifier, or FunctionExpression.

I intentionally kept the test cases to clear side effects, in case we want to loosen the checks later.

Is there anything you'd like reviewers to focus on?

Not really.

lib/rules/no-extra-bind.js Outdated Show resolved Hide resolved
@platinumazure

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2018

@mysticatea Good idea. I've just pushed a commit to fix that.

@mysticatea
Copy link
Member

left a comment

LGTM, thank you!

@btmills
Copy link
Member

left a comment

LGTM. I like the approach of starting out conservatively 👍

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit d12be69 into master Oct 12, 2018

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the issue10846 branch Oct 12, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.