Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: single- and multiline const, let, var statements (fixes #10721) #10919

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@neemzy
Copy link
Contributor

commented Oct 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#10721

What changes did you make? (Give an overview)

  • Added new STATEMENT_TYPEs for multiline variable declarations (multiline-const, multiline-let, multiline-var, singleline-const, singleline-let, single-line-var)
@jsf-clabot

This comment has been minimized.

Copy link

commented Oct 5, 2018

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Oct 5, 2018

@neemzy neemzy changed the title Upgrade: added separate statement types for multiline variable declarations in padding-line-between-statements rule (fixes #10721) Upgrade: discriminated multiline variable declarations (fixes #10721) Oct 5, 2018

@neemzy neemzy changed the title Upgrade: discriminated multiline variable declarations (fixes #10721) Upgrade: discriminated singe-line and multiline variable declarations (fixes #10721) Nov 5, 2018

@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

PR was updated as requested in #10721: singleline-* STAMEMENT_TYPEs were also added to allow for discrimination while preserving backwards compatibility.

@neemzy neemzy changed the title Upgrade: discriminated singe-line and multiline variable declarations (fixes #10721) Upgrade: single- and multiline const, let, var statements (fixes #10721) Nov 5, 2018

@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

@platinumazure @not-an-aardvark Is that OK for you guys? :)

@platinumazure
Copy link
Member

left a comment

This implementation is looking good so far. Sorry for losing track of this.

Just one request: Could you add some tests that use the multiline-var option with a single line var statement (and vice versa, and for let/const) which show that the "wrong" options don't lint for those cases? Thanks!

@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

@platinumazure Done, thanks!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks! Just want some more eyes on this.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Oh, can you take a look at the Contributor License Agreement issue? We can't merge this without you signing the CLA. Thanks!

@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

@platinumazure Hmm, that's strange, I signed it when I first opened the PR and can't sign it again if I check the details (fields are disabled and there is no submit button anyway). See https://imgur.com/a/ROMQPZy

@not-an-aardvark

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

@neemzy It seems like your git commit was created with a different email address (tpanier at synbioz dot com) than the one associated with your GitHub account, which is why the CLA check is now failing. One way to fix it would be to amend the commit to make sure the correct email is used, or to add the other email address to your GitHub account.

@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 23, 2018

@not-an-aardvark Ah, right, my bad. It's fixed!

@platinumazure platinumazure added accepted and removed evaluating labels Nov 23, 2018

@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2018

@platinumazure Are we waiting for more approvals from the team? :)

@nzakas nzakas changed the title Upgrade: single- and multiline const, let, var statements (fixes #10721) Update: single- and multiline const, let, var statements (fixes #10721) Dec 7, 2018

@nzakas
nzakas approved these changes Dec 7, 2018
Copy link
Member

left a comment

LGTM

@nzakas

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@kaicataldo @not-an-aardvark any objections to merging this?

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 4b0f517 into eslint:master Dec 8, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@neemzy

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2018

Thanks! :)

@eslint eslint bot locked and limited conversation to collaborators Jun 7, 2019

@eslint eslint bot added the archived due to age label Jun 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.