Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-invalid-regexp disallows \ at end of pattern (fixes #10861) #10920

merged 1 commit into from Oct 9, 2018


Copy link

commented Oct 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix: fixes #10861.

What changes did you make? (Give an overview)

This PR upgrades regexpp package to 2.0.1 which fixed this bug (mysticatea/regexpp@0dc0b65), and adds a test case.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint eslint bot added the triage label Oct 5, 2018

@mysticatea mysticatea added bug rule accepted and removed triage labels Oct 5, 2018

Copy link

left a comment

LGTM, thanks!

@mysticatea mysticatea merged commit 5fe0e1a into master Oct 9, 2018

5 checks passed

commit-message Commit message follows guidelines
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
licence/cla Contributor License Agreement is signed.
release-monitor No patch release is pending

@mysticatea mysticatea deleted the issue10861 branch Oct 9, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 8, 2019

@eslint eslint bot added the archived due to age label Apr 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
4 participants
You can’t perform that action at this time.