Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: no-tabs allowIndentationTabs option (fixes #10256) #10925

Merged
merged 1 commit into from Oct 12, 2018

Conversation

@platinumazure
Copy link
Member

commented Oct 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

See #10256.

What changes did you make? (Give an overview)

Added new option to no-tabs: allowIndentationTabs. This allows tabs that occur before any tokens or comments on a line.

Is there anything you'd like reviewers to focus on?

Any more test cases I should add?

I also noticed that the rule was reporting incorrect column locations and fixed that issue along with the existing tests. Please take a look at those changes and make sure I got them right.

@btmills
Copy link
Member

left a comment

LGTM. Nice job catching the off-by-one columns as well!

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 5fd1bda into master Oct 12, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the issue10256 branch Oct 12, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.