Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update working-with-parsers link #10929

merged 1 commit into from Oct 8, 2018


Copy link

commented Oct 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
The file seems to have been renamed so updating the link to point to the new file.

Is there anything you'd like reviewers to focus on?


This comment has been minimized.

Copy link

commented Oct 6, 2018

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Oct 6, 2018

@azeemba azeemba changed the title Update working-with-parsers link Docs: Update working-with-parsers link Oct 6, 2018

@azeemba azeemba force-pushed the azeemba:patch-1 branch from 87510db to 4bd0e8e Oct 6, 2018

Copy link

left a comment

LGTM, but see the comment I left inline 😄

docs/developer-guide/ Outdated Show resolved Hide resolved
Docs: Update working-with-parsers link
The file seems to have been renamed so updating the link too.

@azeemba azeemba force-pushed the azeemba:patch-1 branch from 4bd0e8e to 6e416b9 Oct 6, 2018

@platinumazure platinumazure merged commit 3dccac4 into eslint:master Oct 8, 2018

5 checks passed

commit-message Commit message follows guidelines
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
licence/cla Contributor License Agreement is signed.
release-monitor No patch release is pending

This comment has been minimized.

Copy link

commented Oct 8, 2018

Merged. Thanks @azeemba for contributing!

@azeemba azeemba deleted the azeemba:patch-1 branch Oct 8, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 7, 2019

@eslint eslint bot added the archived due to age label Apr 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
4 participants
You can’t perform that action at this time.