Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add more test cases to space-infix-ops #10936

Merged
merged 1 commit into from Oct 7, 2018

Conversation

@madbence
Copy link
Contributor

commented Oct 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Added some test cases with more interesting ASTs.

Is there anything you'd like reviewers to focus on?

((a)) + ((b)) and (((a))) + (((b))) are especially interesting, because this is the only case when there are more than 5 tokens between a and b.

@eslint eslint bot added the triage label Oct 7, 2018

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark added chore and removed triage labels Oct 7, 2018

@not-an-aardvark not-an-aardvark merged commit fe8111a into eslint:master Oct 7, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@madbence madbence deleted the madbence:space-infix-ops-add-tests branch Oct 8, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 6, 2019

@eslint eslint bot added the archived due to age label Apr 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.