Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cannot read property 'range' of null error with one-var (#10937) #10938

Merged
merged 1 commit into from Oct 12, 2018

Conversation

@jkrup
Copy link
Contributor

commented Oct 8, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#10937

What changes did you make? (Give an overview)
If there is no tokenAfterDeclarator when mapping over the declarators, return null rather than attempt to access a property on the null object.

Is there anything you'd like reviewers to focus on?
Nothing in particular 馃槃

@eslint eslint bot added the triage label Oct 8, 2018

@jkrup jkrup force-pushed the jkrup:issue10937 branch from 4711b06 to 0c42fcc Oct 8, 2018

@jkrup jkrup force-pushed the jkrup:issue10937 branch from 0c42fcc to e4ae48c Oct 8, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks! (Would like another set of eyes on this before merging.)

@platinumazure platinumazure added bug rule accepted and removed triage labels Oct 8, 2018

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks! Waiting a bit longer before merging (in general, we usually leave bugfix PRs open for at least 48 hours), but this should get merged soon unless someone else raises an objection.

@btmills
Copy link
Member

left a comment

LGTM, thanks @jkrup! Merging this in for the release today.

@btmills btmills merged commit 543edfa into eslint:master Oct 12, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.