Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for no-unsafe-finally #10945

Merged
merged 1 commit into from Oct 9, 2018

Conversation

@taueres
Copy link
Contributor

commented Oct 9, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
The comment erroneously said 1 is returned but the value returned is 0.

@jsf-clabot

This comment has been minimized.

Copy link

commented Oct 9, 2018

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Oct 9, 2018

@taueres taueres force-pushed the taueres:fix-comment-unsafe-finally branch from 3828700 to c3c6bc9 Oct 9, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

Note to merger: Add "Docs:" prefix to commit summary.

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 95c4cb1 into eslint:master Oct 9, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@taueres taueres deleted the taueres:fix-comment-unsafe-finally branch Oct 10, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 8, 2019

@eslint eslint bot added the archived due to age label Apr 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.