Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-unused-vars false pos. with markVariableAsUsed (fixes #10952) #10954

Merged
merged 1 commit into from Oct 12, 2018

Conversation

@webOS101
Copy link
Contributor

commented Oct 10, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

#10952

What changes did you make? (Give an overview)
Added check to isAfterLastUsedArg() to recognize variables used by context.markVariableAsUsed()

Is there anything you'd like reviewers to focus on?
I did not check other situations for where context.markVariableAsUsed() may be ignored. Also, I was not certain whether isAfterLastUsedArg() should just be calling isUsedVariable() and that function should be updated to check for eslintUsed.

@jsf-clabot

This comment has been minimized.

Copy link

commented Oct 10, 2018

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Oct 10, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks for contributing!

We usually wait about 48 hours before merging bugfix PRs to ensure other team members have a chance to review. But barring any objections, I see no reason this won't get into this week's release.

@platinumazure platinumazure added bug rule accepted and removed triage labels Oct 10, 2018

@btmills
Copy link
Member

left a comment

LGTM, thanks @webOS101!

@not-an-aardvark
Copy link
Member

left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 847372f into eslint:master Oct 12, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.