Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Using deconstruction assignment for shelljs #10974

Merged
merged 1 commit into from Oct 13, 2018

Conversation

@ZYSzys
Copy link
Contributor

commented Oct 13, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Bit of refactor, using deconstruction assignment instead of require the whole shelljs modules.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 13, 2018

@not-an-aardvark
Copy link
Member

left a comment

Looks good to me, thanks for contributing!

@not-an-aardvark not-an-aardvark merged commit d45b184 into eslint:master Oct 13, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

@ZYSzys ZYSzys deleted the zys-contribs:refactor branch Oct 13, 2018

aladdin-add added a commit that referenced this pull request Oct 17, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.