Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: eslint-release@1.0.0 (refs #10631) #10991

Merged
merged 1 commit into from Oct 19, 2018

Conversation

@not-an-aardvark
Copy link
Member

commented Oct 17, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This upgrades eslint-release to 1.0.0. The new version of eslint-release has a separate "generate" and "publish" phase, to allow for a 2FA code to be supplied in between. As a side-effect, it's now possible to manually test most aspects of the release process (by running npm run generate-release) without actually publishing a release somewhere. In lieu of unit tests, this should make it easier to test changes to the release process, like this one. (I tested running npm run generate-release and npm run generate-alpharelease locally, and ensured that everything got generated properly.)

(refs #10631)

Is there anything you'd like reviewers to focus on?

Nothing in particular

Upgrade: eslint-release@1.0.0 (refs #10631)
This upgrades `eslint-release` to 1.0.0. The new version of `eslint-release` has a separate "generate" and "publish" phase, to allow for a 2FA code to be supplied in between. As a side-effect, it's now possible to manually test most aspects of the release process (by running `npm run generate-release`) without actually publishing a release somewhere. In lieu of unit tests, this should make it easier to test changes to the release process, like this one.
@platinumazure
Copy link
Member

left a comment

LGTM, but another set of eyes would be ideal. Thanks!

@kaicataldo
Copy link
Member

left a comment

LGTM. Thanks for working on this!

@kaicataldo kaicataldo merged commit 2f87bb3 into master Oct 19, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the upgrade-eslint-release branch Oct 19, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.