Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not strip underscores in camelcase allow (fixes #11000) #11001

Merged
merged 2 commits into from Nov 28, 2018

Conversation

@lukeapage
Copy link
Contributor

commented Oct 21, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

refactor when the name is stripped so it doesn't affect the allow option

Is there anything you'd like reviewers to focus on?

@jsf-clabot

This comment has been minimized.

Copy link

commented Oct 21, 2018

CLA assistant check
All committers have signed the CLA.

@eslint eslint bot added the triage label Oct 21, 2018
Copy link
Member

left a comment

Thanks for contributing! Could you please add a unit test that fails without your fix, but passes with your fix?

@lukeapage lukeapage force-pushed the lukeapage:patch-2 branch from d0f467a to 2a521dd Oct 21, 2018
@lukeapage lukeapage force-pushed the lukeapage:patch-2 branch from 2a521dd to 0b7a3ea Oct 21, 2018
@lukeapage

This comment has been minimized.

Copy link
Contributor Author

commented Oct 21, 2018

yep, done

@lukeapage

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

@platinumazure please can you re review now I added a test?

Copy link
Member

left a comment

LGTM, but would like another set of eyes on this.

@lukeapage

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

Any idea how I can get a second review?

@platinumazure

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@lukeapage Hope and pray, I guess? Just kidding.

I'll ask for another review in our team chat. Thank you for following up!

@nzakas
nzakas approved these changes Nov 28, 2018
@platinumazure platinumazure merged commit c0a80d0 into eslint:master Nov 28, 2018
5 checks passed
5 checks passed
commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@lukeapage Merged, thanks for contributing! (And I do apologize for the long delay.)

@eslint eslint bot locked and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.