Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Create Linter.version API (fixes #9271) #11010

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@nzakas
Copy link
Member

commented Oct 23, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added Linter.version. I used a getter because JavaScript doesn't yet have static class properties, and otherwise, I'd need to do some hacky thing to add a property to the Linter constructor. I think this makes sense since Linter.version should not be overwritten.

Is there anything you'd like reviewers to focus on?

Is this what was expected?

@nzakas nzakas requested a review from not-an-aardvark Oct 23, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@nzakas nzakas merged commit 3943635 into master Oct 24, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@nzakas nzakas deleted the issue9271 branch Oct 24, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.