New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add karma-chrome-launcher support #11027

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
4 participants
@aladdin-add
Copy link
Member

aladdin-add commented Oct 28, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain:

What changes did you make? (Give an overview)
the change was merged in #10898, but was reverted in #10973, due to a release build failing on Jenkins.

the change added it back again, and added puppeteer in dev, to fix the build failing.

Is there anything you'd like reviewers to focus on?

what can we do to make sure it fixed the issue? (e.g. run on Jenkins)

@g-plane
Copy link
Member

g-plane left a comment

Missing process.env.CHROME_BIN = require("puppeteer").executablePath() at the header of karma.conf.js.

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Nov 7, 2018

Apologies if this was discussed elsewhere, but: Why do we want to do this in the first place? Is this to help validate our unofficial browser capability?

@aladdin-add

This comment has been minimized.

Copy link
Member

aladdin-add commented Nov 7, 2018

I think it was discussed in #10898. it was introduced as Phantomjs no longer being maintained, than to help validate our unofficial browser capability.

aladdin-add added some commits Oct 17, 2018

@aladdin-add aladdin-add force-pushed the revert-10973-revert-chrome-headless branch from 25a2dce to c3a7aaa Nov 7, 2018

@aladdin-add aladdin-add closed this Nov 8, 2018

@aladdin-add aladdin-add reopened this Nov 26, 2018

@aladdin-add aladdin-add requested a review from not-an-aardvark Dec 26, 2018

@g-plane

This comment has been minimized.

Copy link
Member

g-plane commented Jan 4, 2019

Once we are going to use Chrome, babel-core, babelify, babel-polyfill and babel-preset-es2015 can be removed.

@aladdin-add

This comment has been minimized.

Copy link
Member

aladdin-add commented Jan 4, 2019

@g-plane switching to chrome does not mean dropping support IE. so I'm not sure we can remove these deps. but it seems a good idea to upgrade babel 7, since babel-* were no longer maintained.

@not-an-aardvark
Copy link
Member

not-an-aardvark left a comment

LGTM, thanks!

I created a test build on the Jenkins server and confirmed that the tests on this branch pass.

@not-an-aardvark

This comment has been minimized.

Copy link
Member

not-an-aardvark commented Jan 4, 2019

Ignoring the CLA checker because the name changed and the email address is the same (also see #11220 (comment)).

@not-an-aardvark not-an-aardvark merged commit f92d6f0 into master Jan 4, 2019

4 of 5 checks passed

licence/cla Contributor License Agreement is not signed yet.
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the revert-10973-revert-chrome-headless branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment