Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ignore empty statements in no-unreachable (fixes #9081) #11058

Merged
merged 2 commits into from Nov 8, 2018

Conversation

@nzakas
Copy link
Member

commented Nov 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Made no-unreachable ignore EmptyStatement nodes.

Is there anything you'd like reviewers to focus on?

Was this the correct approach?

@nzakas nzakas added bug rule labels Nov 6, 2018

@nzakas nzakas requested a review from mysticatea Nov 6, 2018

@ljharb

ljharb approved these changes Nov 6, 2018

Copy link
Contributor

left a comment

Seems good to me!

@mysticatea
Copy link
Member

left a comment

Thank you for this fix!

But I think that the right approach is another one: delete L188.

lib/rules/no-unreachable.js Outdated Show resolved Hide resolved
@nzakas

This comment has been minimized.

Copy link
Member Author

commented Nov 7, 2018

Should be all set now.

@mysticatea
Copy link
Member

left a comment

LGTM, thank you!

@mysticatea mysticatea merged commit dcc6233 into master Nov 8, 2018

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@mysticatea mysticatea deleted the issue9081 branch Nov 8, 2018

@eslint eslint bot locked and limited conversation to collaborators May 8, 2019

@eslint eslint bot added the archived due to age label May 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.