Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update ecmaVersion to include 2019/10 values #11059

Merged
merged 1 commit into from Nov 9, 2018

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Nov 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)

It seems this is already used in the codebase and is needed for parsing new features like optional catch binding.

Is there anything you'd like reviewers to focus on?

No.

@eslint eslint bot added the triage label Nov 6, 2018

@aladdin-add aladdin-add closed this Nov 8, 2018

@aladdin-add aladdin-add reopened this Nov 8, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@kaicataldo
Copy link
Member

left a comment

LGTM. Thanks for contributing!

@aladdin-add aladdin-add merged commit 3dd7493 into eslint:master Nov 9, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@aladdin-add

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

merged. Thanks for contributing!

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-configuring-ecmaversion-2019 branch Nov 9, 2018

@eslint eslint bot locked and limited conversation to collaborators May 9, 2019

@eslint eslint bot added the archived due to age label May 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.