Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-restricted-imports to check re-export (fixes #9678) #11064

Merged
merged 2 commits into from Nov 9, 2018

Conversation

@nzakas
Copy link
Member

commented Nov 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added checks to no-restricted-imports to check for re-export using export * from 'foo' and export {f} from 'foo' syntax forms.

Is there anything you'd like reviewers to focus on?

Did I miss anything?

@eslint eslint bot added the triage label Nov 7, 2018

@nzakas nzakas added bug rule and removed triage labels Nov 7, 2018

@aladdin-add aladdin-add closed this Nov 8, 2018

@aladdin-add aladdin-add reopened this Nov 8, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks! But I'd love to get another set of eyes on this in case I missed something.

@platinumazure
Copy link
Member

left a comment

Oops, need to request a change: Can the PR title for this change start with "Update:" since this increases warnings?

@btmills

btmills approved these changes Nov 9, 2018

Copy link
Member

left a comment

LGTM, thanks! Like @platinumazure mentioned, we should be sure to change the commit message when squashing.

I'll change the PR tag during merging 👍

@btmills btmills merged commit 79a2797 into master Nov 9, 2018

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the issue9678 branch Feb 21, 2019

@eslint eslint bot locked and limited conversation to collaborators May 9, 2019

@eslint eslint bot added the archived due to age label May 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.