Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Espree v5.0.0 #11161

Merged
merged 1 commit into from Dec 8, 2018

Conversation

@kaicataldo
Copy link
Member

commented Dec 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Upgrading to Espree v5.0.0 (which removes comment attachment).

What changes did you make? (Give an overview)
Upgrade espree from ^4.0.0 to ^5.0.0.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@eslint eslint bot added the triage label Dec 5, 2018
@kaicataldo kaicataldo force-pushed the espreev5 branch from 6156b2b to 76a0e4c Dec 5, 2018
@kaicataldo kaicataldo added upgrade and removed triage labels Dec 5, 2018
Copy link
Member

left a comment

LGTM, thanks!

@jaydenseric

This comment has been minimized.

Copy link

commented Dec 6, 2018

Hopefully it will fix this warning on installation:

npm WARN acorn-jsx@5.0.1 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
$ npm ls acorn-jsx
[redacted]
└─┬ eslint@5.9.0
  └─┬ espree@4.1.0
    └── acorn-jsx@5.0.1
$ npm ls acorn
[redacted]
└─┬ next@7.0.2
  └─┬ webpack@4.20.2
    ├── acorn@5.7.3
    └─┬ acorn-dynamic-import@3.0.0
      └── acorn@5.7.3  deduped
@platinumazure

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@jaydenseric It won't, as this is an npm bug (see this comment for more information).

@not-an-aardvark not-an-aardvark merged commit f850726 into master Dec 8, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@not-an-aardvark not-an-aardvark deleted the espreev5 branch Dec 8, 2018
@eslint eslint bot locked and limited conversation to collaborators Jun 7, 2019
@eslint eslint bot added the archived due to age label Jun 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.