Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Ensure triage label is added to new issues #11182

Merged
merged 2 commits into from Dec 12, 2018
Merged

Conversation

@not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Dec 10, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

This updates the issue templates to ensure that the triage label is added to new issues. The bot had stopped adding the triage label to issues as an unintended side-effect of #11163.

(fixes eslint/eslint-github-bot#99)

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark
Copy link
Member Author

@not-an-aardvark not-an-aardvark commented Dec 10, 2018

Marking as "evaluating" because there is ongoing discussion in eslint/eslint-github-bot#99 about the right solution.

Copy link
Member

@nzakas nzakas left a comment

I'd like to see "evaluating" removed from each issue template. As discussed in eslint/eslint-github-bot#99, I think the progression from triage -> evaluating -> accepted is important to maintain.

@not-an-aardvark
Copy link
Member Author

@not-an-aardvark not-an-aardvark commented Dec 11, 2018

Updated the templates to avoid adding "evaluating".

nzakas
nzakas approved these changes Dec 12, 2018
Copy link
Member

@nzakas nzakas left a comment

LGTM. Thanks!

@not-an-aardvark not-an-aardvark merged commit d5eb108 into master Dec 12, 2018
4 checks passed
@aladdin-add aladdin-add deleted the add-triage-label branch Dec 14, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants