Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Chore: use local function to append "s" instead of a package #11293
What changes did you make? (Give an overview)
Use a local function to append "s" instead of an npm package.
The proposed code matches the way other formatters in ESLint handle pluralization, which seems simple enough to not require an additional package for.
platinumazure left a comment
LGTM in general.
I think it would be slightly better to pluralize only the word "Error" or "Warning" without having the number in the string, but I won't consider it a blocker.
Waiting for another set of eyes before merging. Thanks!