Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: bundle espree (fixes eslint/eslint.github.io#546) #11467

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@aladdin-add
Copy link
Member

aladdin-add commented Mar 3, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
fixes eslint/eslint.github.io#546

Is there anything you'd like reviewers to focus on?

the commit message checking failing -- how to fix a cross-repo issue?

@aladdin-add aladdin-add force-pushed the aladdin-add:build/espree branch from 77852ef to 4d85aa2 Mar 3, 2019

@aladdin-add aladdin-add changed the title Build: bundle espree (fixes eslint/espree#546) Build: bundle espree (fixes eslint/eslint.github.io#546) Mar 3, 2019

Show resolved Hide resolved webpack.config.js Outdated

g-plane and others added some commits Mar 3, 2019

Update webpack.config.js
Co-Authored-By: aladdin-add <weiran.zsd@outlook.com>
@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Mar 3, 2019

Thanks for the PR!

I think the bot just never had to worry about cross-repository fixes before- we could certainly enhance to allow that case. I wouldn't have a problem merging this with the commit message "error", assuming any other issues are fixed.

@platinumazure
Copy link
Member

platinumazure left a comment

LGTM, thanks!

@platinumazure platinumazure requested a review from not-an-aardvark Mar 4, 2019

@not-an-aardvark
Copy link
Member

not-an-aardvark left a comment

I'm not familiar with how webpack config files work, but this seems fine if we've confirmed that it works.

@g-plane

g-plane approved these changes Mar 5, 2019

@not-an-aardvark not-an-aardvark merged commit fe1a892 into eslint:master Mar 5, 2019

4 of 5 checks passed

commit-message PR title doesn't follow commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details

@aladdin-add aladdin-add deleted the aladdin-add:build/espree branch Mar 5, 2019

@g-plane g-plane referenced this pull request Mar 5, 2019

Merged

Fix: correct loading espree #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.