Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: avoid creating invalid regex in no-warning-comments (fixes #11471) #11472
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
What changes did you make? (Give an overview)
5018378 changed the codebase to use unicode regexes almost everywhere, with the exception of places where regexes are constructed from user input. However, two issues occurred to cause a bug:
This commit fixes the first issue. The second issue isn't a problem on its own, but it will need to be fixed in order to implement #11423.
Is there anything you'd like reviewers to focus on?
Nothing in particular