Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
New: allowAfterThisConstructor for no-underscore-dangle (fixes #11488) #11489
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
What changes did you make? (Give an overview)
Implemented a new option for
Is there anything you'd like reviewers to focus on?
See rationale in issue.
platinumazure left a comment •
The code/docs/tests look good to me, thanks!
Only one request: If you have time, could you please ensure the commit message says
You can do this one of two ways:
EDIT: Thinking about it, we could also just fix that on merge. But if you have time to fix the message on your end, it will reduce the chance of a mistake on our end.
I'll go ahead and to the force push since that's alright with you. Will be easiest.