Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: make no-redeclare stricter (fixes #11370, fixes #11405) #11509

Merged
merged 17 commits into from Apr 25, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

fix engines.node to use Object.entries

  • Loading branch information...
mysticatea committed Mar 15, 2019
commit 9b05f8abe3061902318190eae70103bbd50814e5
@@ -124,6 +124,6 @@
],
"license": "MIT",
"engines": {
"node": "^6.14.0 || ^8.10.0 || >=9.10.0"
"node": "^8.10.0 || ^10.13.0 || >=11.10.1"
This conversation was marked as resolved by mysticatea

This comment has been minimized.

Copy link
@not-an-aardvark

not-an-aardvark Mar 15, 2019

Member

Can we make this change in a separate PR?

This comment has been minimized.

Copy link
@mysticatea

mysticatea Mar 15, 2019

Author Member

Yeah, I noted it in the PR description:

Changes engines.node to use Object.entries for now (this is the reason that this PR has "don't merge" label. I assume this PR will be merged after the PR which updates engines.node was merged.)

This comment has been minimized.

Copy link
@not-an-aardvark

not-an-aardvark Mar 15, 2019

Member

Oh, sorry, I missed that. Ok, sounds fine to me.

}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.